AsmBB

Power
Login Register

Problem with unicode tag in rwasa server

#16068 (ツ) ganuonglachanh
Last edited: 22.03.2020 by ganuonglachanh , read: 299 times
#16079 (ツ) johnfound
Created 22.03.2020, read: 292 times
ganuonglachanh

The tag хабр.наполеон worked in Asmbb in nginx

https://board.asm32.info/хабр.наполеон/

But doesn't work with rwasa server setup :-P

That is because nginx correctly encodes the unicode URLs with percent encoding.

RWASA sends them in some non UTF-8 encoding (I am not sure what exactly). Maybe in the encoding the web browser made the request?...

I will see what can be done about this problem.

#16082 (ツ) johnfound
Created 22.03.2020, read: 280 times

Well, after some debugging, I have found the problem. It is a bug in rwasa. I will report it and it will be definitely fixed.

#16083 (ツ) ganuonglachanh
Created 23.03.2020, read: 267 times
johnfound

Well, after some debugging, I have found the problem. It is a bug in rwasa. I will report it and it will be definitely fixed.

Thanks johnfound! rofl

#16157 (ツ) ganuonglachanh
Created 01.06.2020, read: 46 times

Hi johnfound

Do you know any fix has been done in rwasa? I could try patching rwasa if you show me some hints :-)

Thank you!

#16158 (ツ) johnfound
Created 01.06.2020, read: 45 times
ganuonglachanh

Hi johnfound

Do you know any fix has been done in rwasa? I could try patching rwasa if you show me some hints :-)

Thank you!

Unfortunately, I was not able to contact Jeff Marrison, the author of RWASA. Will try again a little bit later. Sorry for the delay.

#16159 (ツ) jacky
Created 02.06.2020, read: 32 times
ganuonglachanh

Hi johnfound

Do you know any fix has been done in rwasa? I could try patching rwasa if you show me some hints :-)

Thank you!

ganuonglachanh 我觉得你可以尝试下。 I think you can try it.

#16160 (ツ) johnfound
Last edited: 02.06.2020 by johnfound, read: 27 times

OK, I have some news about this issue. At the end I was able to contact with Jeff Marrison. Now he knows about the bug and will probably fix it soon.

But he mentioned that he is fairly busy these days and the official fix can delay a little. Well, with this corona-chaos in the world it is not so unusual.

That is why I will post here my fix of the problem. But notice, that I am not so familiar with the RWASA code and this fix can be buggy or even non-secure at all. For example it can make RWASA crash or leak memory in some circumstances. It works on my tests, but may not work for you. Use at your own risk. 😀

The bug is in the file url.inc in the main directory of the HeavyThing library.

I will attach both - the diff file and the fixed source file.

Check it and report the issues. If they are easy to fix, I will fix them. If not, well, will wait for the Jeff's fix.

Regards

Attached files:
FileSizeUploadedDownloadsMD5 hash
url.inc53035 bytes02.06.2020335191663a3d2f2ca1eb51dcdb91d6ead
url.patch4177 bytes02.06.20204884b3fa6705646b1937785aa40ec72ba
#16161 (ツ) ganuonglachanh
Created 02.06.2020, read: 16 times

Thanks you johnfound

I can confirm it worked in my Rwasa build, will look in url$decode and url$decode_path function to understand your cool patch.

Really appreciate your help!

rofl

#16162 (ツ) johnfound
Created 02.06.2020, read: 13 times
ganuonglachanh

Thanks you johnfound

I can confirm it worked in my Rwasa build, will look in url$decode and url$decode_path function to understand your cool patch.

Really appreciate your help!

rofl

I am glad it works for you, but still would suggest to update to the official fix, once released. Consider my patch as a quick and dirty hack, because it has been made without full understanding of the RWASA code and dependencies.

Problem with unicode tag in rwasa server

AsmBB v2.8 (check-in: 6348f13102432a47); SQLite v3.31.1 (check-in: 3bfa9cc97da10598);
©2016..2020 John Found; Licensed under EUPL. Powered by Assembly language Created with Fresh IDE