AsmBB

Power
Login Register
Threads Categories Chat

Minor bugs in dev trunks

0 1
ganuonglachanh (ツ)

in main_html_start.tpl

user-scallable=no => user-scalable=no

Will update this post if found in latest dev trunks :-)

johnfound (ツ)

fixed

ganuonglachanh (ツ)

Can't add code block in Modern Theme

code block

in dev trunk, select text and press code block, nothing happen

ganuonglachanh (ツ)

In http://127.0.0.1/!post

var attch = document.getElementById("attachments");

in HTML no element with id "attachments", maybe you forgot something? => error in JS console

johnfound (ツ)
ganuonglachanh

Can't add code block in Modern Theme

code block

in dev trunk, select text and press code block, nothing happen

Stupid typo - fixed.

johnfound (ツ)
ganuonglachanh

In http://127.0.0.1/!post

var attch = document.getElementById("attachments");

in HTML no element with id "attachments", maybe you forgot something? => error in JS console

Fixed. It is because this JS code was copy/pasted from the form_edit.tpl; In the "new post" and "new thread" forms, the attachments can't be edited because the post is not created in the database yet.

ganuonglachanh (ツ)

http://127.0.0.1/!chat

line 509:

discinect(); -> should be disconnect();

===============================

http://127.0.0.1/!search/?s=test&u=&x=25&y=15

Console error:

GET http://127.0.0.1/templates/Light/_images/edited.svg 404 (Gone Walkabout)

Reason: in http://127.0.0.1/templates/Light/search.css?skin=/templates/Light, 3 last line:

background-image: url("/templates/Light/_images/edited.svg");

===============================

Theme Light and MoLight: new AsmBB Powered Logo has white background => can't see it :-)

johnfound (ツ)
ganuonglachanh

http://127.0.0.1/!chat

line 509:

discinect(); -> should be disconnect();

===============================

http://127.0.0.1/!search/?s=test&u=&x=25&y=15

Console error:

GET http://127.0.0.1/templates/Light/_images/edited.svg 404 (Gone Walkabout)

Reason: in http://127.0.0.1/templates/Light/search.css?skin=/templates/Light, 3 last line:

background-image: url("/templates/Light/_images/edited.svg");

===============================

Theme Light and MoLight: new AsmBB Powered Logo has white background => can't see it :-)

Fixed.

ganuonglachanh (ツ)

Hi Johnfound

I don't know whether it's a bug or not :-)

In post.asm and edit.asm

mov eax, LIMIT_POST_LENGTH stdcall GetParam, 'max_post_length', gpInteger ; => not found in DB setting?? stdcall StrByteUtf8, [.source], eax stdcall StrTrim, [.source], eax

I'm learning Asmbb source code so please don't mind my beginner questions rofl

johnfound (ツ)
ganuonglachanh

Hi Johnfound

I don't know whether it's a bug or not :-)

In post.asm and edit.asm

mov eax, LIMIT_POST_LENGTH stdcall GetParam, 'max_post_length', gpInteger ; => not found in DB setting?? stdcall StrByteUtf8, [.source], eax stdcall StrTrim, [.source], eax

I'm learning Asmbb source code so please don't mind my beginner questions rofl

The mechanism here is the following: GetParam will keep all registers not changed, if a parameter with the given name is not located in the database. (It returns CF=1 in this case, but it is not important right here) or will return the value of the parameter in EAX if this parameter exists in the database.

So, here, first the hard coded fall-back parameter LIMIT_POST_LENGTH is loaded in EAX, then an attempt to read the user limit, stored in the max_post_length in the database is made.

If the attempt succeed, the value in EAX will be changed. If not, the values in EAX will remain unchanged, equal to the hard-coded LIMIT_POST_LENGTH.

ganuonglachanh (ツ)
johnfound
ganuonglachanh

Hi Johnfound

I don't know whether it's a bug or not :-)

In post.asm and edit.asm

mov eax, LIMIT_POST_LENGTH stdcall GetParam, 'max_post_length', gpInteger ; => not found in DB setting?? stdcall StrByteUtf8, [.source], eax stdcall StrTrim, [.source], eax

I'm learning Asmbb source code so please don't mind my beginner questions rofl

The mechanism here is the following: GetParam will keep all registers not changed, if a parameter with the given name is not located in the database. (It returns CF=1 in this case, but it is not important right here) or will return the value of the parameter in EAX if this parameter exists in the database.

So, here, first the hard coded fall-back parameter LIMIT_POST_LENGTH is loaded in EAX, then an attempt to read the user limit, stored in the max_post_length in the database is made.

If the attempt succeed, the value in EAX will be changed. If not, the values in EAX will remain unchanged, equal to the hard-coded LIMIT_POST_LENGTH.

Thanks johnfound, clear as crystal, so we can set the max_post_length param by SQL console since it's not exist in default Database.

johnfound (ツ)
ganuonglachanh

Thanks johnfound, clear as crystal, so we can set the max_post_length param by SQL console since it's not exist in default Database.

Yes, exactly.

ganuonglachanh (ツ)

Hi johnfound

The post content seem to be duplicated, it exists in : Posts.Content, PostFTS_content and PostFTS.Content.

Can we optimize a little bit here?

ganuonglachanh (ツ)

I enable debug Mode and see this on command line, may be sse event?

Stack top address: $FFF50864 Initial personality: $00400000 Switch to 3GB address space. sys_personality return EAX:4194304 Stack top address: $BFD7A294 The program switched to 3GB address space. Listener added: 0884EA30 Listener added: 08851050 Listener added: 0884E620 Remove event listener: 0884E620 Listener added: B7F9A760 Remove event listener: B7F9A760 Listener added: 0884E620 Remove event listener: 0884E620 Listener added: 0884E5B0 WARNING: StrDel on pointer: 0806DCF0 call from: 080495FB Listener added: 0884B780 Remove event listener: 08851050 WARNING: StrDel on pointer: 0806DCF0 call from: 080495FB Listener added: 08851840 WARNING: StrDel on pointer: 0806DCF0 call from: 080495FB Listener added: 0884E620 Remove event listener: 08851840 Remove event listener: 0884B780 Remove event listener: 0884EA30 Listener added: 08851C00 Remove event listener: 08851C00 Listener added: 0884D9C0 WARNING: StrDel on pointer: 0806DCF0 call from: 080495FB Listener added: 0884EFD0 Remove event listener: 0884E620
johnfound (ツ)

These are information messages when SSE listener is added and removed to the engine. Nothing interesting.

The real problem might be the message "WARNING: StrDel on pointer" - this is strong indication for a bug.

What is the check-in number of the engine tested?

ganuonglachanh

I enable debug Mode and see this on command line, may be sse event?

Stack top address: $FFF50864 Initial personality: $00400000 Switch to 3GB address space. sys_personality return EAX:4194304 Stack top address: $BFD7A294 The program switched to 3GB address space. Listener added: 0884EA30 Listener added: 08851050 Listener added: 0884E620 Remove event listener: 0884E620 Listener added: B7F9A760 Remove event listener: B7F9A760 Listener added: 0884E620 Remove event listener: 0884E620 Listener added: 0884E5B0 WARNING: StrDel on pointer: 0806DCF0 call from: 080495FB Listener added: 0884B780 Remove event listener: 08851050 WARNING: StrDel on pointer: 0806DCF0 call from: 080495FB Listener added: 08851840 WARNING: StrDel on pointer: 0806DCF0 call from: 080495FB Listener added: 0884E620 Remove event listener: 08851840 Remove event listener: 0884B780 Remove event listener: 0884EA30 Listener added: 08851C00 Remove event listener: 08851C00 Listener added: 0884D9C0 WARNING: StrDel on pointer: 0806DCF0 call from: 080495FB Listener added: 0884EFD0 Remove event listener: 0884E620
ganuonglachanh (ツ)

It's the latest in trunk and when I refresh this url:

http://127.0.0.1/!debuginfo

johnfound (ツ)
ganuonglachanh

It's the latest in trunk and when I refresh this url:

http://127.0.0.1/!debuginfo

It was easy. Fixed. ;-)

ganuonglachanh (ツ)

Hi johnfound

I have a crash and here is the log in fault.txt , hope you can find any clue about it:

eax = 00000AF0 ebx = B7F8F978 ecx = 00000026 edx = 00000AF1 esi = 6FF1ECFD edi = 08F7AD98 ebp = B7F8F978 esp = B7D64BC4

:-)

johnfound (ツ)
ganuonglachanh

Hi johnfound

I have a crash and here is the log in fault.txt , hope you can find any clue about it:

eax = 00000AF0 ebx = B7F8F978 ecx = 00000026 edx = 00000AF1 esi = 6FF1ECFD edi = 08F7AD98 ebp = B7F8F978 esp = B7D64BC4

:-)

Is this the whole content of fault.txt? The address of the crash and the stack trace are much more important.

Also, it is important what is the exact check-in version of the engine. Because recently I have fixed an old bug that happened to crash the engine.

ganuonglachanh (ツ)
0 1

Minor bugs in dev trunks

©2016..2020 John Found; Licensed under EUPL; AsmBB v2.8 (check-in: 6d0d9d4bca1af5dd); SQLite v3.31.1 (check-in: 3bfa9cc97da10598); Powered by Assembly language; Created with Fresh IDE;